Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gatsby 5 upgrade release #946

Merged
merged 36 commits into from
Sep 1, 2023
Merged

Gatsby 5 upgrade release #946

merged 36 commits into from
Sep 1, 2023

Conversation

sunnyzanchi
Copy link
Contributor

No description provided.

LizBaker and others added 30 commits July 31, 2023 13:48
this makes sure the portal div is there for both client and server
so we don't get any hydration issues. this changes the Popover component
to render the portal conditionally so the DOM matches at first
`Button` can be used with the `as` prop,
which makes `variant` not make much sense
Update schema to have the type Mdx contain an mdxAST field to maintain feature parity with Gatsby v4. Add remark and remark-mdx to accomplish this, but needed older versions to use require syntax
when `externals` is an object here, it overwrite's Gatsby's `externals`
config, which causes all sorts of errors with the different modules that
their `externals` defines, like `util` and `stream`.
making our `externals` an array appends them to Gatsby's,
instead of replacing theirs
previously this was a dependency of Gatsby, but no longer
there are slightly different classnames bc of the emotion upgrade
as part of the upgrade to Gatsby 5, the `css` prop wasn't working on
styled components or regular JSX tags, but _only_ in templates.
regular pages are fine.
i spent days trying to figure out wtf was going on and wasn't able to

Liz figured out that switching from the `css` prop to `styled` works,
so instead of toiling away at a heap of config files, we can just do this
code blocks are now rendered as `pre` tags from MDX,
and inline code tags are rendered as `code` tags
the anchors in headers were offsetting headers to the right.
they weren't getting the styles they should have.
i think this might have to do with the emotion issue.
this fixes the issue by adding the expected styles with
a custom class name
@sunnyzanchi sunnyzanchi requested review from a team, clarkmcadoo and LizBaker and removed request for a team September 1, 2023 15:57
@sunnyzanchi sunnyzanchi merged commit b491233 into main Sep 1, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants